linux-ext4 - Re: [PATCH] e2fsck: fix quota accounting to use cluster units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170413154747.vb473ynqri2nevjm@thunk.org>
Date:   Thu, 13 Apr 2017 11:47:47 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck: fix quota accounting to use cluster units

On Sun, Apr 02, 2017 at 12:57:05PM -0400, Eric Whitney wrote:
> The quota accounting code in e2fsck's pass 1 and pass 3 uses block units
> rather than cluster units when recording the allocated space consumed by
> files and directories.  In pass 1, this causes a large undercount of
> actual quota results and test failures for xfstests generic/383, /384,
> /385, and /386 on bigalloc file systems.  In pass 3, this results in
> quota accounting errors when the lost+found directory is either extended
> or recreated on a bigalloc file system.
> 
> Use clusters rather than blocks when accounting for allocated space,
> and correct a related header comment in the quota code.
> 
> Note that pass 1b also contains call sites for quota_data_sub() that
> also need to be addressed.  However, it appears that more than just
> unit conversion may be needed, so that will be left to a future patch.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Thanks, applied.

					- Ted