linux-ext4 - Re: [PATCH] ext4: error should be cleared if ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeU0aP-v4YZN05MH=gREEpE2AORUmHSqUKkxuOQ43BvWD268g@mail.gmail.com>
Date:   Tue, 11 Jul 2017 21:37:16 -0700
From:   Tahsin Erdogan <tahsin@...gle.com>
To:     Emoly Liu <emoly.liu@...el.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: error should be cleared if ea_inode isn't added to
 the cache

Reviewed-by: tahsin@...gle.com

On Tue, Jul 11, 2017 at 8:56 PM, Emoly Liu <emoly.liu@...el.com> wrote:
> For Lustre, if ea_inode fails in hash validation but passes parent
> inode and generation checks, it won't be added to the cache as well
> as the error "-EFSCORRUPTED" should be cleared, otherwise it will
> cause "Structure needs cleaning" when running getfattr command.
>
> Signed-off-by: Emoly Liu <emoly.liu@...el.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9723
> ---
>  fs/ext4/xattr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index cff4f41..de217a0 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -451,6 +451,7 @@ static int ext4_xattr_inode_iget(struct inode *parent, unsigned long ea_ino,
>                 }
>                 /* Do not add ea_inode to the cache. */
>                 ea_inode_cache = NULL;
> +               err = 0;
>         } else if (err)
>                 goto out;
>
> --
> 1.8.3.1
>