linux-ext4 - Re: [PATCH] ext4: error should be cleared if ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B1CD93E6-0D69-4837-BC0F-8548A5E8473A@dilger.ca>
Date:   Wed, 12 Jul 2017 22:17:58 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Emoly Liu <emoly.liu@...el.com>, Theodore Ts'o <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: error should be cleared if ea_inode isn't added to
 the cache

On Jul 11, 2017, at 9:37 PM, Tahsin Erdogan <tahsin@...gle.com> wrote:
> 
> Reviewed-by: tahsin@...gle.com
> 
> On Tue, Jul 11, 2017 at 8:56 PM, Emoly Liu <emoly.liu@...el.com> wrote:
>> For Lustre, if ea_inode fails in hash validation but passes parent
>> inode and generation checks, it won't be added to the cache as well
>> as the error "-EFSCORRUPTED" should be cleared, otherwise it will
>> cause "Structure needs cleaning" when running getfattr command.
>> 
>> Signed-off-by: Emoly Liu <emoly.liu@...el.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

This could also include:

  Fixes: dec214d00e0d78a08b947d7dccdfdb84407a9f4d

unless this fix is merged into the original patch.

>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9723
>> ---
>> fs/ext4/xattr.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
>> index cff4f41..de217a0 100644
>> --- a/fs/ext4/xattr.c
>> +++ b/fs/ext4/xattr.c
>> @@ -451,6 +451,7 @@ static int ext4_xattr_inode_iget(struct inode *parent, unsigned long ea_ino,
>>                }
>>                /* Do not add ea_inode to the cache. */
>>                ea_inode_cache = NULL;
>> +               err = 0;
>>        } else if (err)
>>                goto out;




Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)