linux-ext4 - Re: [PATCH v4 3/3] ext4: Add IOMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170725121644.GF19943@quack2.suse.cz>
Date:   Tue, 25 Jul 2017 14:16:44 +0200
From:   Jan Kara <jack@...e.cz>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v4 3/3] ext4: Add IOMAP_REPORT support for inline data

On Fri 07-07-17 23:28:01, Andreas Gruenbacher wrote:
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 82f3f7d..e2b0a8a 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3361,8 +3361,13 @@ static int ext4_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
>  	bool delalloc = false;
>  	int ret;
>  
> -	if (WARN_ON_ONCE(ext4_has_inline_data(inode)))
> -		return -ERANGE;
> +	if (ext4_has_inline_data(inode)) {
> +		if (WARN_ON_ONCE(!(flags & IOMAP_REPORT)))
> +			return -ERANGE;
> +		if (!ext4_inline_data_iomap(inode, iomap) &&
> +		    offset < iomap->length)

Hum, what's the thinking behind this "offset < iomap->length" check? If it
fails, we'd just fall through to the normal case which I'm not sure is
guaranteed to be safe? Shouldn't we return error instead?

								Honza

> +			return 0;
> +	}
>  
>  	map.m_lblk = first_block;
>  	map.m_len = last_block - first_block + 1;
> -- 
> 2.7.5
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR