linux-ext4 - Re: [PATCH v2 6/7] quota: swapping s_prj_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A9C5B4B9-7216-4D13-ACA2-2AC2C301C062@dilger.ca>
Date:   Mon, 20 Nov 2017 14:25:58 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v2 6/7] quota: swapping s_prj_quota_inum superblock field

On Nov 14, 2017, at 12:04 AM, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> ext2fs_swap_super() swaps s_usr_quota_inum and
> s_grp_quota_inum fields but not s_prj_quota_inum.
> 
> This patch adds s_prj_quota_inum swapping.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@...il.com>

You can add my:

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

I would suggest this patch just be submitted separately, since it is a
bug fix that could go into the "maint" branch along with other project
quota functionality, and doesn't really relate to the inode64 feature.

> ---
> lib/ext2fs/swapfs.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ext2fs/swapfs.c b/lib/ext2fs/swapfs.c
> index b7c01005..60cdf124 100644
> --- a/lib/ext2fs/swapfs.c
> +++ b/lib/ext2fs/swapfs.c
> @@ -81,6 +81,7 @@ void ext2fs_swap_super(struct ext2_super_block * sb)
> 	sb->s_snapshot_r_blocks_count =
> 		ext2fs_swab64(sb->s_snapshot_r_blocks_count);
> 	sb->s_snapshot_list = ext2fs_swab32(sb->s_snapshot_list);
> +	sb->s_prj_quota_inum = ext2fs_swab32(sb->s_prj_quota_inum);
> 	sb->s_usr_quota_inum = ext2fs_swab32(sb->s_usr_quota_inum);
> 	sb->s_grp_quota_inum = ext2fs_swab32(sb->s_grp_quota_inum);
> 	sb->s_overhead_blocks = ext2fs_swab32(sb->s_overhead_blocks);


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)