linux-ext4 - Re: [PATCH v2 4/7] debugfs: 64bit inode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C5A042E-350C-4C9A-A2EE-80B571ACD7C1@dilger.ca>
Date:   Mon, 20 Nov 2017 13:22:49 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v2 4/7] debugfs: 64bit inode support

On Nov 14, 2017, at 12:04 AM, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> New dirdata type EXT2_DIRENT_INODE is added.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@...il.com>
> ---
> debugfs/ls.c         | 6 ++++--
> lib/ext2fs/ext2_fs.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/debugfs/ls.c b/debugfs/ls.c
> index 5655933e..b67c0800 100644
> --- a/debugfs/ls.c
> +++ b/debugfs/ls.c
> @@ -64,11 +64,13 @@ static void list_dirdata(struct list_dir_struct *ls,
> 
> 		dlen = data[0];
> 
> -		if (dirdata_mask == EXT2_DIRENT_LUFID) {
> +		if (dirdata_mask == EXT2_DIRENT_INODE)
> +			fprintf(ls->f, "ino64:%04\n", *(__u32 *)(data + 1));
> +		else if (dirdata_mask == EXT2_DIRENT_LUFID) {

(style) add {} around first part of if/else if needed on any part.

Looks fine otherwise.  You could add my:

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)