linux-ext4 - Re: [PATCH] ext4: fix fdatasync(2) after fallocate(2) operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171204040147.mhe6zom6h4mbx7cg@thunk.org>
Date:   Sun, 3 Dec 2017 23:01:47 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eryu Guan <eguan@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix fdatasync(2) after fallocate(2) operation

On Wed, Nov 15, 2017 at 07:54:19PM +0800, Eryu Guan wrote:
> Currently, fallocate(2) with KEEP_SIZE followed by a fdatasync(2)
> then crash, we'll see wrong allocated block number (stat -c %b), the
> blocks allocated beyond EOF are all lost. fstests generic/468
> exposes this bug.
> 
> Commit 67a7d5f561f4 ("ext4: fix fdatasync(2) after extent
> manipulation operations") fixed all the other extent manipulation
> operation paths such as hole punch, zero range, collapse range etc.,
> but forgot the fallocate case.
> 
> So similarly, fix it by recording the correct journal tid in ext4
> inode in fallocate(2) path, so that ext4_sync_file() will wait for
> the right tid to be committed on fdatasync(2).
> 
> Signed-off-by: Eryu Guan <eguan@...hat.com>

Thanks, applied.

						- Ted