lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.20.1801021458360.24055@hadrien> Date: Tue, 2 Jan 2018 15:00:46 +0100 (CET) From: Julia Lawall <julia.lawall@...6.fr> To: Bob Peterson <rpeterso@...hat.com> cc: dev@...nvswitch.org, linux-s390@...r.kernel.org, linux-media@...r.kernel.org, linux-scsi@...r.kernel.org, dccp@...r.kernel.org, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, cluster-devel@...hat.com, amd-gfx@...ts.freedesktop.org, Namhyung Kim <namhyung@...nel.org>, linux-ext4@...r.kernel.org, Jiri Olsa <jolsa@...hat.com>, linux-arm-kernel@...ts.infradead.org, esc storagedev <esc.storagedev@...rosemi.com> Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline On Tue, 2 Jan 2018, Bob Peterson wrote: > ----- Original Message ----- > | ----- Original Message ----- > | | Drop newline at the end of a message string when the printing function adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source code for output strings, > | this patch set goes against the accepted Linux coding style document. See: > | > | https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings > | > | Regards, > | > | Bob Peterson > | > | > Hm. I guess I stand corrected. The document reads: > > "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > and I don't like the thought of re-combining them all. Actually, the point of the patch was to remove the unnecessary \n at the end of the string, because log_print will add another one. If you prefer to keep the string broken up, I can resend the patch in that form, but without the unnecessary \n. julia
Powered by blists - more mailing lists