lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+55aFyNbcS8k3x1WrZ1-Ymtr6OpnCJ8NUZXBUCfacwWXYzC+g@mail.gmail.com> Date: Mon, 22 Jan 2018 12:25:56 -0800 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Deepa Dinamani <deepa.kernel@...il.com> Cc: Al Viro <viro@...iv.linux.org.uk>, "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>, y2038 Mailman List <y2038@...ts.linaro.org> Subject: Re: [PATCH v6 3/4] vfs: Add timestamp_truncate() api On Sun, Jan 21, 2018 at 6:04 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote: > + t.tv_nsec -= t.tv_nsec % gran; This doesn't actuall ywork if tv_nsec is negative. Which may not be an issue in most cases, but did somebody check utimensat() or whatever? > + WARN(1, "illegal file time granularity: %u", gran); .. small nit: we generally should use 'invalid' rather than 'illegal'. No cops will hunt you down for things like this. Linus
Powered by blists - more mailing lists