lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABeXuvogBWfTzteb8RFAGnW_HGLQX=hVUj0_SZ-TP1ZeNj=OHA@mail.gmail.com> Date: Tue, 23 Jan 2018 08:25:35 -0800 From: Deepa Dinamani <deepa.kernel@...il.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Al Viro <viro@...iv.linux.org.uk>, "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>, y2038 Mailman List <y2038@...ts.linaro.org> Subject: Re: [PATCH v6 3/4] vfs: Add timestamp_truncate() api On Mon, Jan 22, 2018 at 12:25 PM, Linus Torvalds <torvalds@...ux-foundation.org> wrote: > On Sun, Jan 21, 2018 at 6:04 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote: >> + t.tv_nsec -= t.tv_nsec % gran; > > This doesn't actuall ywork if tv_nsec is negative. Right. > Which may not be an issue in most cases, but did somebody check > utimensat() or whatever? I checked POSIX again. There is no mention of tv_nsec being positive always for utimes. And, the long term plan is to replace all the callers of timespec_trunc() to use this new api instead for filesystems. So this will need to be fixed. I will fix this and post an update. >> + WARN(1, "illegal file time granularity: %u", gran); > > .. small nit: we generally should use 'invalid' rather than 'illegal'. Will update this as well. Thanks, Deepa
Powered by blists - more mailing lists