linux-ext4 - Re: [PATCH v3 1/7] e2fsck: add support for dirdata feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <120B9076-98BA-4529-90E6-2A8CA76BB650@dilger.ca>
Date:   Wed, 7 Mar 2018 22:32:22 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>,
        Zhenyu Xu <bobijam.xu@...el.com>,
        Manisha Salve <msalve@....com>
Subject: Re: [PATCH v3 1/7] e2fsck: add support for dirdata feature

On Mar 6, 2018, at 8:18 AM, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> -#define EXT2_DIR_REC_LEN(name_len)	(((name_len) + \
> +#define __EXT2_DIR_REC_LEN(name_len)	(((name_len) + \
> 					  EXT2_DIR_ENTRY_HEADER_LEN + \
> 					  EXT2_DIR_ROUND) & \
> 					 ~EXT2_DIR_ROUND)
> 
> +#define EXT2_DIR_REC_LEN(de)	(__EXT2_DIR_REC_LEN(((de)->name_len &         \
> +						     EXT2_NAME_LEN) +         \
> +						    ext2_get_dirdata_size(de)))

It would be good to rename these to match the macro names used in the
ext4 kernel patch accepted upstream.

> @@ -2900,6 +2901,13 @@ int main (int argc, char *argv[])
> 		exit(1);
> 	}
> 
> +	if (ext2fs_has_feature_inline_data(fs->super) &&
> +	    ext2fs_has_feature_dirdata(fs->super)) {
> +		printf("%s", _("The dirdata feature can not enabled "
> +			       "with inline data feature.\n"));

Is this something that is fixed in a later patch?  I don't recall the
details of why these two features do not work together...  I can imagine
in the case of inline directories that there is additional complexity
in handling dirdata packed inside the inode xattr space, but for regular
files (i.e. most files in a filesystem) the dirdata and inline data
features are orthogonal and it would be useful to have both enabled.

Obviously not something to implement in this patch, but definitely
something that would be useful to have in a follow-on patch.

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)