linux-ext4 - Re: [PATCH v3 3/7] debugfs: 64bit inode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8D1EBDCD-FF24-4D72-A946-DB37EC534EFD@dilger.ca>
Date:   Wed, 7 Mar 2018 22:36:01 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v3 3/7] debugfs: 64bit inode support


> On Mar 6, 2018, at 8:18 AM, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> New dirdata type EXT2_DIRENT_INODE is added.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@...il.com>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> ---
> debugfs/ls.c         | 6 ++++--
> lib/ext2fs/ext2_fs.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/debugfs/ls.c b/debugfs/ls.c
> index a7a5dae8..57b84c7e 100644
> --- a/debugfs/ls.c
> +++ b/debugfs/ls.c
> @@ -87,11 +87,13 @@ static void list_dirdata(struct list_dir_struct *ls,
> 
> 		dlen = data[0];
> 
> -		if (dirdata_mask == EXT2_DIRENT_LUFID) {
> +		if (dirdata_mask == EXT2_DIRENT_INODE) {
> +			fprintf(ls->f, "ino64:%04\n", *(__u32 *)(data + 1));
> +		} else if (dirdata_mask == EXT2_DIRENT_LUFID) {
> 			struct lu_fid *fid = (struct lu_fid *)(data + 1);
> 
> 			fid_be_to_cpu(fid, fid);
> -			fprintf(ls->f, DFID, PFID(fid));
> +			fprintf(ls->f, "fid:"DFID, PFID(fid));

My only suggestion might be to include the "fid:" prefix in the original
1/7 patch so that the 4/7 test works properly regardless of whether this
patch is applied or not.

> 		} else {
> 			int i;
> 
> diff --git a/lib/ext2fs/ext2_fs.h b/lib/ext2fs/ext2_fs.h
> index 9de6bdf9..980072f7 100644
> --- a/lib/ext2fs/ext2_fs.h
> +++ b/lib/ext2fs/ext2_fs.h
> @@ -1041,6 +1041,7 @@ struct ext2_dir_entry_tail {
> /* lu_fid size and NUL char */
> #define EXT2_DIRENT_LUFID_SIZE		16
> #define EXT2_DIRENT_LUFID		0x10
> +#define EXT2_DIRENT_INODE		0x20
> 
> /*
>  * Constants for ext4's extended time encoding
> --
> 2.14.3 (Apple Git-98)
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)