linux-ext4 - Re: [PATCH] ext4: fix bitmap position validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180430164507.GC20585@thunk.org>
Date:   Mon, 30 Apr 2018 12:45:07 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: fix bitmap position validation

On Mon, Apr 30, 2018 at 10:24:53AM +0200, Lukas Czerner wrote:
> 
> Well, so much for a discussion :-/ The patch is upstream now...

Sorry, it's been crazy busy and there were other fixes I really needed
to get upstream.

If it really is superfluous, the compiler will optimize it away.  I
have been bitten more times than I can count with fuzz testers and C's
_fine_ signed vs. unsigned integer semantics.  So I prefer to be
careful here.

If we can really be sure it's safe, we can always remove the extra
comparison in a separate patch, since that's unrelated to the real bug
we're trying to fix.

						- Ted