linux-ext4 - Re: [PATCH] ext4: fix bitmap position validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180502114432.lsq3j4tegp2d5t2c@rh_laptop>
Date:   Wed, 2 May 2018 13:44:32 +0200
From:   Lukas Czerner <lczerner@...hat.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: fix bitmap position validation

On Mon, Apr 30, 2018 at 12:45:07PM -0400, Theodore Y. Ts'o wrote:
> On Mon, Apr 30, 2018 at 10:24:53AM +0200, Lukas Czerner wrote:
> > 
> > Well, so much for a discussion :-/ The patch is upstream now...
> 
> Sorry, it's been crazy busy and there were other fixes I really needed
> to get upstream.

Yeah, I understand.

> 
> If it really is superfluous, the compiler will optimize it away.  I
> have been bitten more times than I can count with fuzz testers and C's
> _fine_ signed vs. unsigned integer semantics.  So I prefer to be
> careful here.
> 
> If we can really be sure it's safe, we can always remove the extra
> comparison in a separate patch, since that's unrelated to the real bug
> we're trying to fix.

That's fine, I understand that it was better to fix it sooner rather
than later and deal with the optimization at a different time. Short
reply stating that would have helped though, there is my sign-off below
the patch as well after all.

-Lukas

> 
> 						- Ted