linux-ext4 - Re: [PATCH 2/2] ext4: use raw i_version value for ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 May 2018 11:56:13 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Eryu Guan <guaneryu@...il.com>
Cc:     linux-ext4@...r.kernel.org,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Tahsin Erdogan <tahsin@...gle.com>
Subject: Re: [PATCH 2/2] ext4: use raw i_version value for ea_inode

On Thu, Apr 26, 2018 at 07:20:27PM +0800, Eryu Guan wrote:
> Currently, creating large xattr (e.g. 2k) in ea_inode would cause
> ea_inode refcount corruption, e.g.
> 
>   Pass 4: Checking reference counts
>   Extended attribute inode 13 ref count is 0, should be 1. Fix? no
> 
> This is because that we save the lower 32bit of refcount in
> inode->i_version and store it in raw_inode->i_disk_version on disk.
> But since commit ee73f9a52a34 ("ext4: convert to new i_version
> API"), we load/store modified i_disk_version from/to disk instead of
> raw value, which causes on-disk ea_inode refcount corruption.
> 
> Fix it by loading/storing raw i_version/i_disk_version, because it's
> a self-managed value in this case.
> 
> Fixes: ee73f9a52a34 ("ext4: convert to new i_version API")
> Cc: Tahsin Erdogan <tahsin@...gle.com>
> Signed-off-by: Eryu Guan <guaneryu@...il.com>

Applied, thanks.

						- Ted