linux-ext4 - Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180510160958.GB4111@magnolia>
Date:   Thu, 10 May 2018 09:09:58 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     tytso@....edu, Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

On Sat, May 05, 2018 at 10:04:52PM +0200, Mathieu Malaterre wrote:
> Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static,
> make it so. Remove the following gcc warning (W=1):
> 
>   fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Sorry about being late to the party,

Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/ext4/fsmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/fsmap.c b/fs/ext4/fsmap.c
> index e871c4bf18e9..4b99e2db95b8 100644
> --- a/fs/ext4/fsmap.c
> +++ b/fs/ext4/fsmap.c
> @@ -402,8 +402,8 @@ static void ext4_getfsmap_free_fixed_metadata(struct list_head *meta_list)
>  }
>  
>  /* Find all the fixed metadata in the filesystem. */
> -int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
> -				      struct list_head *meta_list)
> +static int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
> +					     struct list_head *meta_list)
>  {
>  	struct ext4_group_desc *gdp;
>  	ext4_group_t agno;
> -- 
> 2.11.0
>