linux-ext4 - Re: [PATCH 1/3] generic/459: use xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxgEF7cHmb05AxFJyHaV1zWC+Zk08dDNPepfhZ0Foz31Hg@mail.gmail.com>
Date:   Tue, 15 May 2018 08:25:49 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Dave Chinner <david@...morbit.com>
Cc:     Eryu Guan <guaneryu@...il.com>, "Theodore Ts'o" <tytso@....edu>,
        fstests <fstests@...r.kernel.org>,
        Ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze

On Tue, May 15, 2018 at 2:01 AM, Dave Chinner <david@...morbit.com> wrote:
> On Mon, May 14, 2018 at 08:49:49AM +0300, Amir Goldstein wrote:
>> This is what all other tests use as well as _require_freeze
>>
>> Signed-off-by: Amir Goldstein <amir73il@...il.com>
>> ---
>>  tests/generic/459 | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/generic/459 b/tests/generic/459
>> index e755cf7..22b8e62 100755
>> --- a/tests/generic/459
>> +++ b/tests/generic/459
>> @@ -113,7 +113,7 @@ $XFS_IO_PROG -f -d -c 'pwrite -b 1m 0 120m' $SCRATCH_MNT/f1 >>$seqres.full 2>&1
>>  # extended. It is expected, and is only used so xfsaild is triggered to
>>  # flush AIL items, other filesystems usually get remounted as read-only during
>>  # the above write process.
>> -fsfreeze -f $SCRATCH_MNT >>$seqres.full 2>&1 &
>> +xfs_freeze -f $SCRATCH_MNT >>$seqres.full 2>&1 &
>>  freezeid=$!
>>
>>  # Wait enough so xfsaild can run
>> @@ -132,7 +132,7 @@ ret=$?
>>  #    - The filesystem stays in Read-Write mode, but can be frozen/thawed
>>  #      without getting stuck.
>>  if [ $ret -ne 0 ]; then
>> -     # fsfreeze failed, filesystem should reject further writes and remount
>> +     # freeze failed, filesystem should reject further writes and remount
>>       # as readonly. Sometimes the previous write process won't trigger
>>       # ro-remount, e.g. on ext3/4, do additional touch here to make sure
>>       # filesystems see the metadata I/O error.
>> @@ -148,7 +148,7 @@ if [ $ret -ne 0 ]; then
>>  else
>>       # Try to thaw the filesystem, and complete test if if succeed.
>>       # NOTE: This will hang on affected XFS filesystems.
>> -     fsfreeze -u $SCRATCH_MNT >>$seqres.full 2>&1
>> +     xfs_freeze -u $SCRATCH_MNT >>$seqres.full 2>&1
>>       echo "Test OK"
>>  fi
>
> Shouldn't these all be converted to XFS_FREEZE_PROG w/ a setup call
> to export XFS_FREEZE_PROG="`set_prog_path xfs_freeze`"?
>

Yeh, I suppose I can take this one as part of the "freeze" cleanup.

Thanks,
Amir.