linux-ext4 - Re: [PATCH 1/3] generic/459: use xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxikFp-GsuhmPHud4QtKrSdojBNAnDB6yOfrG-11GU_jRw@mail.gmail.com>
Date:   Tue, 15 May 2018 16:50:04 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Dave Chinner <david@...morbit.com>
Cc:     Eryu Guan <guaneryu@...il.com>, "Theodore Ts'o" <tytso@....edu>,
        fstests <fstests@...r.kernel.org>,
        Ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze

On Tue, May 15, 2018 at 8:25 AM, Amir Goldstein <amir73il@...il.com> wrote:
> On Tue, May 15, 2018 at 2:01 AM, Dave Chinner <david@...morbit.com> wrote:
>> On Mon, May 14, 2018 at 08:49:49AM +0300, Amir Goldstein wrote:
>>> This is what all other tests use as well as _require_freeze
>>>
>>> Signed-off-by: Amir Goldstein <amir73il@...il.com>
>>> ---
[...]
>>
>> Shouldn't these all be converted to XFS_FREEZE_PROG w/ a setup call
>> to export XFS_FREEZE_PROG="`set_prog_path xfs_freeze`"?
>>
>
> Yeh, I suppose I can take this one as part of the "freeze" cleanup.
>

I looked again and xfs_freeze pattern repeats itself quite often with
other xfs_* progs, so I guess I'll leave that cleanup for another time...

Thanks,
Amir.

$ git grep -v '^[[:space:]]*[#;]' tests/*/???| grep -v echo > all
$ (cd /usr/sbin; ls xfs_*) > xfsprogs
$ for p in `cat xfsprogs`; do echo $p; grep -w $p all | wc -l; done
xfs_admin
1
xfs_bmap
24
xfs_copy
9
xfs_db
35
xfs_estimate
0
xfs_freeze
17
xfs_fsr
15
xfs_growfs
3
xfs_info
31
xfs_io
17
xfs_logprint
0
xfs_mdrestore
7
xfs_metadump
1
xfs_mkfile
1
xfs_ncheck
0
xfs_quota
43
xfs_rtcp
0
xfs_spaceman
0