linux-ext4 - Re: [PATCH 1/3] generic/459: use xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516004704.GH10363@dastard>
Date:   Wed, 16 May 2018 10:47:04 +1000
From:   Dave Chinner <david@...morbit.com>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Eryu Guan <guaneryu@...il.com>, Theodore Ts'o <tytso@....edu>,
        fstests <fstests@...r.kernel.org>,
        Ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/3] generic/459: use xfs_freeze instead of fsfreeze

On Tue, May 15, 2018 at 04:50:04PM +0300, Amir Goldstein wrote:
> On Tue, May 15, 2018 at 8:25 AM, Amir Goldstein <amir73il@...il.com> wrote:
> > On Tue, May 15, 2018 at 2:01 AM, Dave Chinner <david@...morbit.com> wrote:
> >> On Mon, May 14, 2018 at 08:49:49AM +0300, Amir Goldstein wrote:
> >>> This is what all other tests use as well as _require_freeze
> >>>
> >>> Signed-off-by: Amir Goldstein <amir73il@...il.com>
> >>> ---
> [...]
> >>
> >> Shouldn't these all be converted to XFS_FREEZE_PROG w/ a setup call
> >> to export XFS_FREEZE_PROG="`set_prog_path xfs_freeze`"?
> >>
> >
> > Yeh, I suppose I can take this one as part of the "freeze" cleanup.
> >
> 
> I looked again and xfs_freeze pattern repeats itself quite often with
> other xfs_* progs, so I guess I'll leave that cleanup for another time...

No worries, just add it to the pile...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com