linux-ext4 - Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180622161908.GB29492@linux.intel.com>
Date:   Fri, 22 Jun 2018 10:19:08 -0600
From:   Ross Zwisler <ross.zwisler@...ux.intel.com>
To:     Eryu Guan <guaneryu@...il.com>
Cc:     Ross Zwisler <ross.zwisler@...ux.intel.com>,
        fstests@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Chinner <david@...morbit.com>,
        Christoph Hellwig <hch@....de>, linux-nvdimm@...ts.01.org,
        Jeff Moyer <jmoyer@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

On Fri, Jun 22, 2018 at 10:28:38AM +0800, Eryu Guan wrote:
> On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote:
> > I noticed that in some of my C tests in src/ I was incorrectly checking for
> > mmap() failure by looking for NULL instead of MAP_FAILED.  Fix those and
> > clean up some places where we were testing against -1 (the actual value of
> > MAP_FAILED) which was manually being cast to a pointer.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> 
> BTW, I've applied this patch, no need to resend it in v2.

Okay, thanks for letting me know.