linux-ext4 - Re: [PATCH 04/10] tests: replace perl usage with shell built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180622163233.GF3498@thunk.org>
Date:   Fri, 22 Jun 2018 12:32:33 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 04/10] tests: replace perl usage with shell built-in

On Tue, May 01, 2018 at 10:26:00PM -0600, Andreas Dilger wrote:
> A couple of tests use perl only for generating a string of N characters
> long.  Instead, expand an environment variable to the required length.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied, with the following fix-up.

						- Ted

diff --git a/tests/f_detect_junk/script b/tests/f_detect_junk/script
index ab2a38cb0..12cfdfdff 100644
--- a/tests/f_detect_junk/script
+++ b/tests/f_detect_junk/script
@@ -2,6 +2,7 @@

 if [ "$(grep -c 'define HAVE_MAGIC_H' ../lib/config.h)" -eq 0 ]; then
 	echo "$test_name: skipped (no magic)"
+	exit 0
 fi

 FSCK_OPT=-fn