linux-ext4 - [PATCH] tests: make generated test scripts read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180627095744.32425-1-c17828@cray.com>
Date:   Wed, 27 Jun 2018 12:57:44 +0300
From:   c17828 <artem.blagodarenko@...il.com>
To:     linux-ext4@...r.kernel.org
Cc:     adilger.kernel@...ger.ca, alexey.lyashkov@...il.com,
        Andreas Dilger <andreas.dilger@...el.com>
Subject: [PATCH] tests: make generated test scripts read-only

From: Andreas Dilger <andreas.dilger@...el.com>

Make generated test scripts read-only, to avoid errors by developers
editing the generated test scripts and then having them accidentally
clobbered when "make" is run again.

Change-Id: I60d417b816b7c559b5e05baf4167fc2cf2a871cf
Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
---
 tests/Makefile.in | 6 ++++--
 tests/test_one.in | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.in b/tests/Makefile.in
index 7b9df62a..f97ebc66 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -15,6 +15,7 @@ all:: @DO_TEST_SUITE@ test_one test_script
 
 test_one: $(srcdir)/test_one.in Makefile mke2fs.conf
 	@echo "Creating test_one script..."
+	@[ -f test_one ] && chmod u+w test_one || true
 	@echo "#!/bin/sh" > test_one
 	@echo "HTREE=y" >> test_one
 	@echo "QUOTA=y" >> test_one
@@ -23,14 +24,15 @@ test_one: $(srcdir)/test_one.in Makefile mke2fs.conf
 	@echo "SIZEOF_TIME_T=@...EOF_TIME_T@" >> test_one
 	@echo "DD=@DD@" >>test_one
 	@cat $(srcdir)/test_one.in >> test_one
-	@chmod +x test_one
+	@chmod +x-w test_one
 
 test_script: test_one test_script.in Makefile mke2fs.conf
 	@echo "Creating test_script..."
+	@[ -f test_script ] && chmod u+w test_script || true
 	@echo "#!/bin/sh" > test_script
 	@echo "SRCDIR=@...dir@" >> test_script
 	@cat $(srcdir)/test_script.in >> test_script
-	@chmod +x test_script
+	@chmod +x-w test_script
 
 mke2fs.conf: $(srcdir)/mke2fs.conf.in
 	$(CP) $(srcdir)/mke2fs.conf.in mke2fs.conf
diff --git a/tests/test_one.in b/tests/test_one.in
index c1f18dc8..27e0ca64 100644
--- a/tests/test_one.in
+++ b/tests/test_one.in
@@ -81,6 +81,7 @@ if [ $elapsed -gt 60 -a ! -f $test_dir/is_slow_test ]; then
 		tee $test_name.slow
 	echo "$test_name:  consider adding $test_dir/is_slow_test"
 fi
+[ -f $test_name.failed ] && grep . $test_name.failed
 
 if [ "$SKIP_UNLINK" != "true" ] ; then
 	rm -f $TMPFILE
-- 
2.14.3