linux-ext4 - Re: [PATCH] tests: make generated test scripts read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180702212651.GA26222@thunk.org>
Date:   Mon, 2 Jul 2018 17:26:51 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     c17828 <artem.blagodarenko@...il.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca,
        alexey.lyashkov@...il.com,
        Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH] tests: make generated test scripts read-only

On Wed, Jun 27, 2018 at 12:57:44PM +0300, c17828 wrote:
> diff --git a/tests/test_one.in b/tests/test_one.in
> index c1f18dc8..27e0ca64 100644
> --- a/tests/test_one.in
> +++ b/tests/test_one.in
> @@ -81,6 +81,7 @@ if [ $elapsed -gt 60 -a ! -f $test_dir/is_slow_test ]; then
>  		tee $test_name.slow
>  	echo "$test_name:  consider adding $test_dir/is_slow_test"
>  fi
> +[ -f $test_name.failed ] && grep . $test_name.failed
>

This change has nothing to do with the rest of the patch.  I'm also
not sure it good idea, because sometimes the output of the foo.failed
file can be quite large.  Also, if running multiple tests in parallel
which fail, the output can look quite awful.  Finally, why use "grep ."
instead of "cat"?

I can see possibly adding this to test_script, but it doesn't belong
in test_one, and it should be in its own separate commit.

I'm going to drop this change to test_one.in, but I'll take the rest
of the patch.

					- Ted