linux-ext4 - Re: [PATCH] tests: make generated test scripts read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <818E8B5C-653E-45A5-A1FA-0C086CF5470B@dilger.ca>
Date:   Tue, 3 Jul 2018 11:17:57 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     c17828 <artem.blagodarenko@...il.com>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Alexey Lyashkov <alexey.lyashkov@...il.com>
Subject: Re: [PATCH] tests: make generated test scripts read-only

On Jul 2, 2018, at 3:26 PM, Theodore Y. Ts'o <tytso@....edu> wrote:
> 
> On Wed, Jun 27, 2018 at 12:57:44PM +0300, c17828 wrote:
>> diff --git a/tests/test_one.in b/tests/test_one.in
>> index c1f18dc8..27e0ca64 100644
>> --- a/tests/test_one.in
>> +++ b/tests/test_one.in
>> @@ -81,6 +81,7 @@ if [ $elapsed -gt 60 -a ! -f $test_dir/is_slow_test ]; then
>> 		tee $test_name.slow
>> 	echo "$test_name:  consider adding $test_dir/is_slow_test"
>> fi
>> +[ -f $test_name.failed ] && grep . $test_name.failed
>> 
> 
> This change has nothing to do with the rest of the patch.  I'm also
> not sure it good idea, because sometimes the output of the foo.failed
> file can be quite large.  Also, if running multiple tests in parallel
> which fail, the output can look quite awful.  Finally, why use "grep ."
> instead of "cat"?

The reason for "grep ." instead of "cat" is so that the filename is
prepended to the output.  This is a useful trick when looking at the
content of several files at once.

> I can see possibly adding this to test_script, but it doesn't belong
> in test_one, and it should be in its own separate commit.
> 
> I'm going to drop this change to test_one.in, but I'll take the rest
> of the patch.


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)