linux-ext4 - [PATCH 1/2] overlay: do not set OVL_BASE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Aug 2018 21:29:25 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Eryu Guan <guaneryu@...il.com>
Cc:     Theodore Ts'o <tytso@....edu>, fstests@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-unionfs@...r.kernel.org
Subject: [PATCH 1/2] overlay: do not set OVL_BASE_FSTYP value to "overlay"

The purpose of OVL_BASE_FSTYP is to store the value of FSTYP that is
found in a host config file section.

When there is no host config file or if user sets FSTYP=overlay in config
file, it makes no sense to store the value "overlay" in OVL_BASE_FSTYP
and it is better to leave it empty or leave its current value in tact.

This allows user to set OVL_BASE_FSTYP in config file or before running
the test to support queries about base fs, such as
_require_metadata_journaling, even when running an overlay test.

Signed-off-by: Amir Goldstein <amir73il@...il.com>
---
 common/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/config b/common/config
index 2f1f272..d85519a 100644
--- a/common/config
+++ b/common/config
@@ -530,7 +530,7 @@ _overlay_config_override()
 	[ -b "$TEST_DEV" ] || return 0

 	# Config file may specify base fs type, but we obay -overlay flag
-	export OVL_BASE_FSTYP="$FSTYP"
+	[ "$FSTYP" == overlay ] || export OVL_BASE_FSTYP="$FSTYP"
 	export FSTYP=overlay

 	# Store original base fs vars
-- 
2.7.4