linux-ext4 - [PATCH 2/2] generic/009: fix test failure with overlay over ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Aug 2018 21:29:26 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Eryu Guan <guaneryu@...il.com>
Cc:     Theodore Ts'o <tytso@....edu>, fstests@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-unionfs@...r.kernel.org
Subject: [PATCH 2/2] generic/009: fix test failure with overlay over ext4

When running test with overlayfs and ext4 as base fs, we need to
disable extent zeroout on the underlying base fs.

Signed-off-by: Amir Goldstein <amir73il@...il.com>
---

Eryu,

Suggestions for a cleaner approach are welcome.

Thanks,
Amir.

 tests/generic/009 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/generic/009 b/tests/generic/009
index fa6ef46..a4f56d0 100755
--- a/tests/generic/009
+++ b/tests/generic/009
@@ -39,6 +39,9 @@ testfile=$TEST_DIR/009.$$
 if [ "$FSTYP" = "ext4" ]; then
 	_ext4_disable_extent_zeroout
 fi
+if [ "$FSTYP" = "overlay" -a "$OVL_BASE_FSTYP" = "ext4" ]; then
+	_ext4_disable_extent_zeroout "$OVL_BASE_TEST_DEV"
+fi
 
 # When PAGE_SIZE > 4096 some filesystems extent layout is different so
 # it would not match the output.
-- 
2.7.4