linux-ext4 - [PATCH] ext4: add additinal sanity check for ext4_acl_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180902153540.15343-1-cgxu519@gmx.com>
Date:   Sun,  2 Sep 2018 23:35:40 +0800
From:   Chengguang Xu <cgxu519@....com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, Chengguang Xu <cgxu519@....com>
Subject: [PATCH] ext4: add additinal sanity check for ext4_acl_from_disk()

In the case ACL_USER and ACL_GROUP we check if value has exceeded end,
add same check in the case ACL_OTHER as well.

Signed-off-by: Chengguang Xu <cgxu519@....com>
---
 fs/ext4/acl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index fb50f9aa6ead..9785a559337b 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -52,6 +52,8 @@ ext4_acl_from_disk(const void *value, size_t size)
 		case ACL_OTHER:
 			value = (char *)value +
 				sizeof(ext4_acl_entry_short);
+			if ((char *)value > end)
+				goto fail;
 			break;
 
 		case ACL_USER:
-- 
2.17.1