linux-ext4 - Re: ext4: add additinal sanity check for ext4_acl_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180903143347.GA25806@thunk.org>
Date:   Mon, 3 Sep 2018 10:33:47 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Chengguang Xu <cgxu519@....com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org
Subject: Re: ext4: add additinal sanity check for ext4_acl_from_disk()

On Sun, Sep 02, 2018 at 11:35:40PM +0800, Chengguang Xu wrote:
> In the case ACL_USER and ACL_GROUP we check if value has exceeded end,
> add same check in the case ACL_OTHER as well.
> 
> Signed-off-by: Chengguang Xu <cgxu519@....com>

As Jan pointed out with the ext2 version of this patch, the check is
done earlier in the for loop (in order to make sure it's safe to
dereference entry->e_tag and entry->e_perm).

					- Ted