lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Nov 2018 16:23:56 -0800 From: Omar Sandoval <osandov@...ndov.com> To: Ming Lei <ming.lei@...hat.com> Cc: Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, Dave Chinner <dchinner@...hat.com>, Kent Overstreet <kent.overstreet@...il.com>, Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com, Alexander Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org, Shaohua Li <shli@...nel.org>, linux-raid@...r.kernel.org, linux-erofs@...ts.ozlabs.org, David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org, "Darrick J . Wong" <darrick.wong@...cle.com>, linux-xfs@...r.kernel.org, Gao Xiang <gaoxiang25@...wei.com>, Christoph Hellwig <hch@....de>, Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org, Coly Li <colyli@...e.de>, linux-bcache@...r.kernel.org, Boaz Harrosh <ooo@...ctrozaur.com>, Bob Peterson <rpeterso@...hat.com>, cluster-devel@...hat.com Subject: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs On Thu, Nov 15, 2018 at 04:52:55PM +0800, Ming Lei wrote: > BTRFS is the only user of this helper, so move this helper into > BTRFS, and implement it via bio_for_each_segment_all(), since > bio->bi_vcnt may not equal to number of pages after multipage bvec > is enabled. Shouldn't you also get rid of bio_pages_all() in this patch? > Cc: Dave Chinner <dchinner@...hat.com> > Cc: Kent Overstreet <kent.overstreet@...il.com> > Cc: Mike Snitzer <snitzer@...hat.com> > Cc: dm-devel@...hat.com > Cc: Alexander Viro <viro@...iv.linux.org.uk> > Cc: linux-fsdevel@...r.kernel.org > Cc: Shaohua Li <shli@...nel.org> > Cc: linux-raid@...r.kernel.org > Cc: linux-erofs@...ts.ozlabs.org > Cc: David Sterba <dsterba@...e.com> > Cc: linux-btrfs@...r.kernel.org > Cc: Darrick J. Wong <darrick.wong@...cle.com> > Cc: linux-xfs@...r.kernel.org > Cc: Gao Xiang <gaoxiang25@...wei.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Theodore Ts'o <tytso@....edu> > Cc: linux-ext4@...r.kernel.org > Cc: Coly Li <colyli@...e.de> > Cc: linux-bcache@...r.kernel.org > Cc: Boaz Harrosh <ooo@...ctrozaur.com> > Cc: Bob Peterson <rpeterso@...hat.com> > Cc: cluster-devel@...hat.com > Signed-off-by: Ming Lei <ming.lei@...hat.com> > --- > fs/btrfs/extent_io.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 5d5965297e7e..874bb9aeebdc 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -2348,6 +2348,18 @@ struct bio *btrfs_create_repair_bio(struct inode *inode, struct bio *failed_bio, > return bio; > } > > +static unsigned btrfs_bio_pages_all(struct bio *bio) > +{ > + unsigned i; > + struct bio_vec *bv; > + > + WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED)); > + > + bio_for_each_segment_all(bv, bio, i) > + ; > + return i; > +} > + > /* > * this is a generic handler for readpage errors (default > * readpage_io_failed_hook). if other copies exist, read those and write back > @@ -2368,7 +2380,7 @@ static int bio_readpage_error(struct bio *failed_bio, u64 phy_offset, > int read_mode = 0; > blk_status_t status; > int ret; > - unsigned failed_bio_pages = bio_pages_all(failed_bio); > + unsigned failed_bio_pages = btrfs_bio_pages_all(failed_bio); > > BUG_ON(bio_op(failed_bio) == REQ_OP_WRITE); > > -- > 2.9.5 >
Powered by blists - more mailing lists