lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Nov 2018 16:26:25 -0800 From: Omar Sandoval <osandov@...ndov.com> To: Ming Lei <ming.lei@...hat.com> Cc: Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, Dave Chinner <dchinner@...hat.com>, Kent Overstreet <kent.overstreet@...il.com>, Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com, Alexander Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org, Shaohua Li <shli@...nel.org>, linux-raid@...r.kernel.org, linux-erofs@...ts.ozlabs.org, David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org, "Darrick J . Wong" <darrick.wong@...cle.com>, linux-xfs@...r.kernel.org, Gao Xiang <gaoxiang25@...wei.com>, Christoph Hellwig <hch@....de>, Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org, Coly Li <colyli@...e.de>, linux-bcache@...r.kernel.org, Boaz Harrosh <ooo@...ctrozaur.com>, Bob Peterson <rpeterso@...hat.com>, cluster-devel@...hat.com Subject: Re: [PATCH V10 09/19] block: introduce bio_bvecs() On Thu, Nov 15, 2018 at 04:52:56PM +0800, Ming Lei wrote: > There are still cases in which we need to use bio_bvecs() for get the > number of multi-page segment, so introduce it. > > Cc: Dave Chinner <dchinner@...hat.com> > Cc: Kent Overstreet <kent.overstreet@...il.com> > Cc: Mike Snitzer <snitzer@...hat.com> > Cc: dm-devel@...hat.com > Cc: Alexander Viro <viro@...iv.linux.org.uk> > Cc: linux-fsdevel@...r.kernel.org > Cc: Shaohua Li <shli@...nel.org> > Cc: linux-raid@...r.kernel.org > Cc: linux-erofs@...ts.ozlabs.org > Cc: David Sterba <dsterba@...e.com> > Cc: linux-btrfs@...r.kernel.org > Cc: Darrick J. Wong <darrick.wong@...cle.com> > Cc: linux-xfs@...r.kernel.org > Cc: Gao Xiang <gaoxiang25@...wei.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Theodore Ts'o <tytso@....edu> > Cc: linux-ext4@...r.kernel.org > Cc: Coly Li <colyli@...e.de> > Cc: linux-bcache@...r.kernel.org > Cc: Boaz Harrosh <ooo@...ctrozaur.com> > Cc: Bob Peterson <rpeterso@...hat.com> > Cc: cluster-devel@...hat.com Reviewed-by: Omar Sandoval <osandov@...com> > Signed-off-by: Ming Lei <ming.lei@...hat.com> > --- > include/linux/bio.h | 30 +++++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 1f0dcf109841..3496c816946e 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -196,7 +196,6 @@ static inline unsigned bio_segments(struct bio *bio) > * We special case discard/write same/write zeroes, because they > * interpret bi_size differently: > */ > - > switch (bio_op(bio)) { > case REQ_OP_DISCARD: > case REQ_OP_SECURE_ERASE: > @@ -205,13 +204,34 @@ static inline unsigned bio_segments(struct bio *bio) > case REQ_OP_WRITE_SAME: > return 1; > default: > - break; > + bio_for_each_segment(bv, bio, iter) > + segs++; > + return segs; > } > +} > > - bio_for_each_segment(bv, bio, iter) > - segs++; > +static inline unsigned bio_bvecs(struct bio *bio) > +{ > + unsigned bvecs = 0; > + struct bio_vec bv; > + struct bvec_iter iter; > > - return segs; > + /* > + * We special case discard/write same/write zeroes, because they > + * interpret bi_size differently: > + */ > + switch (bio_op(bio)) { > + case REQ_OP_DISCARD: > + case REQ_OP_SECURE_ERASE: > + case REQ_OP_WRITE_ZEROES: > + return 0; > + case REQ_OP_WRITE_SAME: > + return 1; > + default: > + bio_for_each_bvec(bv, bio, iter) > + bvecs++; > + return bvecs; > + } > } > > /* > -- > 2.9.5 >
Powered by blists - more mailing lists