linux-ext4 - Re: [PATCH 1/3] block number output fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181121233338.GD10588@thunk.org>
Date:   Wed, 21 Nov 2018 18:33:38 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     alexey.lyashkov@...il.com
Cc:     linux-ext4@...r.kernel.org,
        Alexey Lyashkov <alexey.lyashkov@...gate.com>
Subject: Re: [PATCH 1/3] block number output fix.

On Mon, Nov 19, 2018 at 12:16:48PM +0300, alexey.lyashkov@...il.com wrote:
> 
> debugfs lack a support journal tag v3 and block numbers over 2^32
> fix it.

This file is missing a Signed-off-by trailer.

Also please use a subject prefix of "debugfs: " for these patches,
since they are related to debugfs.  I also prefer not having a
trailing period, and use a more descriptive summary so that it's more
understandable what the commit will do when using "git log --oneline".

So, something like:

debugfs: fix logdump to support 64-bit block numbers with v3 journal tags

Thanks,

					- Ted