linux-ext4 - Re: [PATCH 2/3] Fix panic with journal superblock flags printing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181121235432.GE10588@thunk.org>
Date:   Wed, 21 Nov 2018 18:54:32 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     alexey.lyashkov@...il.com
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/3] Fix panic with journal superblock flags printing.

The summary really isn't right; "panic" is something that kernels do,
not userspace programs.

> -	if (dump_super) {
> +	if (dump_all || dump_super) {
>  		e2p_list_journal_super(out_file, jsb_buffer,
> -				       current_fs->blocksize, 0);
> +				       1024, 0);

This makes no sense to me.  Why is hard-coding the expected blocksize
to be 1024 a good thing to do here?

					- Ted