linux-ext4 - Re: [PATCH] ext2fs: Fix build of new superblock fields on BE machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181121162432.GF26006@thunk.org>
Date:   Wed, 21 Nov 2018 11:24:32 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     kernel@...labora.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext2fs: Fix build of new superblock fields on BE machines

On Tue, Nov 20, 2018 at 07:11:27PM -0500, Gabriel Krisman Bertazi wrote:
> New superblock fields must be byte swapped before being accessed in Big
> Endian machines.
> 
> Not tested on an actual BE machine.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
> ---
> 
> I just noticed this today.  I don't see the patch that includes this
> field already pushed to kernel.org, so if you want to squash this one to
> that patch before pushing to make the result more bisectable in BE
> machines, I am ok with that.

Oops, sorry, I just pushed it out before I saw your note.  I'll add it
as a follow-on commit right away.  Fortunately we don't do too much
debugging on BE machines, so it's probably not worth breaking the git
rules and rewinding, even though it's highly unlikely anyone has done
a git pull in the last 10 minutes or so.

While we're at it, I should have noticed this earler before I acceptd
patch 2 in your series.  Could you also send a follow up patch which
adds a quick description of the fname_encoding feature to the ext4.5
man page?

Also, did your v2 patch series to e2fsprogs reflect any of the
comments I made late last night on the rest of the v1 patch series?

Thanks, regards,

						- Ted