linux-ext4 - Re: [RFC][PATCH v5 07/09] ext4: use common file type conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190122100016.GB3245@pathfinder>
Date:   Tue, 22 Jan 2019 10:00:16 +0000
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Jan Kara <jack@...e.cz>
Cc:     tytso@....edu, amir73il@...il.com, viro@...iv.linux.org.uk,
        adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH v5 07/09] ext4: use common file type conversion

On Mon, Jan 21, 2019 at 03:20:48PM +0100, Jan Kara wrote:
> On Mon 21-01-19 00:54:35, Phillip Potter wrote:
> > Deduplicate the ext4 file type conversion implementation and define
> > EXT4_FT_* to match shared FT_* - file systems that use the same file
> > types as defined by POSIX do not need to define their own versions
> > and can use the common helper functions decared in fs_types.h and
> > implemented in fs_types.c
> > 
> > Signed-off-by: Amir Goldstein <amir73il@...il.com>
> > Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> 
> Looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> 								Honza
> 
Dear Jan,

Thank you for this, much appreciated.

Regards,
Phil