linux-ext4 - Re: [PATCH] ext2: Remove redundant check on s_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 11:38:43 +0100
From:   Jan Kara <jack@...e.cz>
To:     Liu Xiang <liu.xiang6@....com.cn>
Cc:     linux-ext4@...r.kernel.org, jack@...e.com,
        linux-kernel@...r.kernel.org, liuxiang_1999@....com
Subject: Re: [PATCH] ext2: Remove redundant check on s_inode_size

On Tue 15-01-19 22:10:43, Liu Xiang wrote:
> The case of (EXT2_INODE_SIZE(sb) == 0) is included in
> (sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE).
> So there is no need to check again.
> 
> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>

Thanks for the cleanup. I have added it to my tree.

								Honza

> ---
>  fs/ext2/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 73b2d52..c71c2e3 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1024,8 +1024,6 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  	sbi->s_frags_per_group = le32_to_cpu(es->s_frags_per_group);
>  	sbi->s_inodes_per_group = le32_to_cpu(es->s_inodes_per_group);
>  
> -	if (EXT2_INODE_SIZE(sb) == 0)
> -		goto cantfind_ext2;
>  	sbi->s_inodes_per_block = sb->s_blocksize / EXT2_INODE_SIZE(sb);
>  	if (sbi->s_inodes_per_block == 0 || sbi->s_inodes_per_group == 0)
>  		goto cantfind_ext2;
> -- 
> 1.9.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR