linux-ext4 - Re: [PATCH] ext2: Remove redundant check for finding no group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190128145128.GB5858@quack2.suse.cz>
Date:   Mon, 28 Jan 2019 15:51:28 +0100
From:   Jan Kara <jack@...e.cz>
To:     Liu Xiang <liu.xiang6@....com.cn>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, liuxiang_1999@....com
Subject: Re: [PATCH] ext2: Remove redundant check for finding no group

On Fri 25-01-19 22:01:36, Liu Xiang wrote:
> When best_desc keeps NULL, best_group keeps -1, too. So we can
> return best_group directly.
> 
> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>

Thanks for the patch! I've added it to my tree.

								Honza

> ---
>  fs/ext2/ialloc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index 5c3d7b7..a0c5ea9 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -222,8 +222,6 @@ static int find_group_dir(struct super_block *sb, struct inode *parent)
>  			best_desc = desc;
>  		}
>  	}
> -	if (!best_desc)
> -		return -1;
>  
>  	return best_group;
>  }
> -- 
> 1.9.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR