linux-ext4 - Re: [PATCH] ext2: Annotate implicit fall through in __ext2_truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 15:51:05 +0100
From:   Jan Kara <jack@...e.cz>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext2: Annotate implicit fall through in
 __ext2_truncate_blocks

On Thu 24-01-19 19:05:04, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1).
> 
> This commit removes the following warnings:
> 
>   fs/ext2/inode.c:1237:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   fs/ext2/inode.c:1244:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Thanks for the patch! I've added it to my tree.

								Honza

> ---
>  fs/ext2/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index e4bb9386c045..e64029b1bd50 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -1239,6 +1239,7 @@ static void __ext2_truncate_blocks(struct inode *inode, loff_t offset)
>  				mark_inode_dirty(inode);
>  				ext2_free_branches(inode, &nr, &nr+1, 1);
>  			}
> +			/* fall through */
>  		case EXT2_IND_BLOCK:
>  			nr = i_data[EXT2_DIND_BLOCK];
>  			if (nr) {
> @@ -1246,6 +1247,7 @@ static void __ext2_truncate_blocks(struct inode *inode, loff_t offset)
>  				mark_inode_dirty(inode);
>  				ext2_free_branches(inode, &nr, &nr+1, 2);
>  			}
> +			/* fall through */
>  		case EXT2_DIND_BLOCK:
>  			nr = i_data[EXT2_TIND_BLOCK];
>  			if (nr) {
> -- 
> 2.19.2
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR