linux-ext4 - Re: [PATCH] jbd2: fix invalid descriptor block checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190301053038.GA7930@mit.edu>
Date:   Fri, 1 Mar 2019 00:30:38 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
CC:     luojiajun <luojiajun3@...wei.com>, <linux-ext4@...r.kernel.org>,
        <jack@...e.com>, <yi.zhang@...wei.com>, <miaoxie@...wei.com>
Subject: Re: [PATCH] jbd2: fix invalid descriptor block checksum

On Tue, Feb 26, 2019 at 01:47:10PM +0100, Jan Kara wrote:
> On Tue 26-02-19 09:31:25, luojiajun wrote:
> > In jbd2_journal_commit_transaction(), if we are in abort mode,
> > we may flush the buffer without setting descriptor block checksum
> > by goto start_journal_io. Then fs is mounted,
> > jbd2_descriptor_block_csum_verify() failed.
> > 
> > [  271.379811] EXT4-fs (vdd): shut down requested (2)
> > [  271.381827] Aborting journal on device vdd-8.
> > [  271.597136] JBD2: Invalid checksum recovering block 22199 in log
> > [  271.598023] JBD2: recovery failed
> > [  271.598484] EXT4-fs (vdd): error loading journal
> > 
> > Fix this problem by keep setting descriptor block checksum if the
> > descriptor buffer is not NULL.
> > 
> > This checksum problem can be reproduced by xfstests generic/388.
> > 
> > Signed-off-by: luojiajun <luojiajun3@...wei.com>
> 
> The patch looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted