linux-ext4 - Re: [PATCH] jbd2: jbd2_get_transaction does not need to return a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190301053947.GB7930@mit.edu>
Date:   Fri, 1 Mar 2019 00:39:47 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
CC:     Liu Song <fishland@...yun.com>, <jack@...e.com>,
        <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <liu.song11@....com.cn>
Subject: Re: [PATCH] jbd2: jbd2_get_transaction does not need to return a
 value

On Tue, Feb 26, 2019 at 05:35:04PM +0100, Jan Kara wrote:
> On Wed 27-02-19 00:07:27, Liu Song wrote:
> > In jbd2_get_transaction, a new transaction is initialized,
> > and set to the j_running_transaction. No need for a return
> > value, so remove it.
> > Also, adjust some comments to match the actual operation
> > of this function.
> > 
> > Signed-off-by: Liu Song <liu.song11@....com.cn>
> 
> Looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

						- Ted