linux-ext4 - Re: [PATCH v2 1/2] ext4: Add missing brelse() in add_new_gdb_meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315041827.GG11334@mit.edu>
Date:   Fri, 15 Mar 2019 00:18:27 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ext4: Add missing brelse() in
 add_new_gdb_meta_bg()

On Tue, Mar 05, 2019 at 11:53:59AM +0100, Lukas Czerner wrote:
> Currently in add_new_gdb_meta_bg() there is a missing brelse of gdb_bh
> in case ext4_journal_get_write_access() fails.
> Additionally kvfree() is missing in the same error path. Fix it by
> moving the ext4_journal_get_write_access() before the ext4 sb update as
> Ted suggested and release n_group_desc and gdb_bh in case it fails.
> 
> Fixes: 61a9c11e5e7a ("ext4: add missing brelse() add_new_gdb_meta_bg()'s error path")
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

					- Ted