linux-ext4 - Re: [PATCH v2 2/2] ext4: Report real fs size after failed resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315042357.GH11334@mit.edu>
Date:   Fri, 15 Mar 2019 00:23:58 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 2/2] ext4: Report real fs size after failed resize

On Tue, Mar 05, 2019 at 11:54:00AM +0100, Lukas Czerner wrote:
> Currently when the file system resize using ext4_resize_fs() fails it
> will report into log that "resized filesystem to <requested block
> count>". However this may not be true in the case of failure. Use the
> current block count as returned by ext4_blocks_count() to report the
> block count.
> Additionally report to log that "error occurred during file system
> resize"
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied with one minor change.  In call to ext4_warning(), I
changed it to include error code so the warning message will be more
useful:

> +	if (err)
> +		ext4_warning(sb, "error occurred during file system resize");

is now

+       if (err)
+               ext4_warning(sb, "error (%d) occurred during "
+                            "file system resize", err);

  				 		 - Ted