linux-ext4 - Re: [PATCH] debugfs: fix encoding handling in dx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 00:07:12 -0400
From:   Gabriel Krisman Bertazi <krisman@...labora.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-ext4@...r.kernel.org,
        Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Subject: Re: [PATCH] debugfs: fix encoding handling in dx_hash command

Eric Biggers <ebiggers@...nel.org> writes:

> From: Eric Biggers <ebiggers@...gle.com>
>
> Fix the following bugs:
>
> 1. 'encoding' and 'hash_flags' are not initialized, causing a segfault.
>
> 2. 'hash_flags' incorrectly uses a __bitwise type.
>
> 3. The optstring doesn't contain "c" or "e", so the -c and -e options
>    aren't recognized.
>
> 4. The code that handles the -e option always returns.
>

Ugly. Thanks for finding it.

Reviewed-by: Gabriel Krisman Bertazi <krisman@...labora.com>


-- 
Gabriel Krisman Bertazi