lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Apr 2019 20:20:55 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: Eric Biggers <ebiggers@...nel.org>, linux-ext4@...r.kernel.org, Gabriel Krisman Bertazi <krisman@...labora.co.uk> Subject: Re: [PATCH] debugfs: fix encoding handling in dx_hash command On Tue, Apr 23, 2019 at 12:07:12AM -0400, Gabriel Krisman Bertazi wrote: > Eric Biggers <ebiggers@...nel.org> writes: > > > From: Eric Biggers <ebiggers@...gle.com> > > > > Fix the following bugs: > > > > 1. 'encoding' and 'hash_flags' are not initialized, causing a segfault. > > > > 2. 'hash_flags' incorrectly uses a __bitwise type. > > > > 3. The optstring doesn't contain "c" or "e", so the -c and -e options > > aren't recognized. > > > > 4. The code that handles the -e option always returns. > > > > Ugly. Thanks for finding it. > > Reviewed-by: Gabriel Krisman Bertazi <krisman@...labora.com> Thanks, applied. - Ted
Powered by blists - more mailing lists