linux-ext4 - Re: [PATCH] quota: honor quote type in Q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190624155425.GJ32376@quack2.suse.cz>
Date:   Mon, 24 Jun 2019 17:54:25 +0200
From:   Jan Kara <jack@...e.cz>
To:     Eric Sandeen <sandeen@...hat.com>
Cc:     Jan Kara <jack@...e.cz>, fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        Bob Peterson <rpeterso@...hat.com>
Subject: Re: [PATCH] quota: honor quote type in Q_XGETQSTAT[V] calls

On Mon 24-06-19 07:45:27, Eric Sandeen wrote:
> On 6/24/19 5:58 AM, Jan Kara wrote:
> > On Fri 21-06-19 18:27:13, Eric Sandeen wrote:
> >> The code in quota_getstate and quota_getstatev is strange; it
> >> says the returned fs_quota_stat[v] structure has room for only
> >> one type of time limits, so fills it in with the first enabled
> >> quota, even though every quotactl command must have a type sent
> >> in by the user.
> >>
> >> Instead of just picking the first enabled quota, fill in the
> >> reply with the timers for the quota type that was actually
> >> requested.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> >> ---
> >>
> >> I guess this is a change in behavior, but it goes from a rather
> >> unexpected and unpredictable behavior to something more expected,
> >> so I hope it's ok.
> >>
> >> I'm working on breaking out xfs quota timers by type as well
> >> (they are separate on disk, but not in memory) so I'll work
> >> up an xfstest to go with this...
> > 
> > Yeah, makes sense. I've added the patch to my tree.
> > 
> > 								Honza
> > 
> 
> Thanks Jan - if you'd like to fix my "quote" for "quota" in the
> subject line, please feel free.  ;)

Done :) Thanks for the patch.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR