lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jun 2019 09:36:42 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: Jan Kara <jack@...e.cz> Cc: matthew.garrett@...ula.com, yuchao0@...wei.com, tytso@....edu, ard.biesheuvel@...aro.org, josef@...icpanda.com, clm@...com, adilger.kernel@...ger.ca, viro@...iv.linux.org.uk, jack@...e.com, dsterba@...e.com, jaegeuk@...nel.org, jk@...abs.org, reiserfs-devel@...r.kernel.org, linux-efi@...r.kernel.org, devel@...ts.orangefs.org, linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org, linux-mm@...ck.org, linux-nilfs@...r.kernel.org, linux-mtd@...ts.infradead.org, ocfs2-devel@....oracle.com, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-btrfs@...r.kernel.org Subject: Re: [PATCH 2/7] vfs: flush and wait for io when setting the immutable flag via SETFLAGS On Mon, Jun 24, 2019 at 05:33:58PM +0200, Jan Kara wrote: > On Fri 21-06-19 16:57:07, Darrick J. Wong wrote: > > +/* > > + * Flush file data before changing attributes. Caller must hold any locks > > + * required to prevent further writes to this file until we're done setting > > + * flags. > > + */ > > +static inline int inode_flush_data(struct inode *inode) > > +{ > > + inode_dio_wait(inode); > > + return filemap_write_and_wait(inode->i_mapping); > > +} > > BTW, how about calling this function inode_drain_writes() instead? The > 'flush_data' part is more a detail of implementation of write draining than > what we need to do to set immutable flag. Ok, that's a much better description of what the function does. --D > > Honza > -- > Jan Kara <jack@...e.com> > SUSE Labs, CR
Powered by blists - more mailing lists