linux-ext4 - Re: [PATCH v2] fs: Fix page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51833696.101442.1575045353332.JavaMail.zimbra@nod.at>
Date:   Fri, 29 Nov 2019 17:35:53 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Darrick <darrick.wong@...cle.com>,
        torvalds <torvalds@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Jeff Layton <jlayton@...nel.org>, Sage Weil <sage@...hat.com>,
        Ilya Dryomov <idryomov@...il.com>, tytso <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>,
        linux-xfs@...r.kernel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Artem Bityutskiy <dedekind1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        ceph-devel@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>,
        linux-btrfs <linux-btrfs@...r.kernel.org>
Subject: Re: [PATCH v2] fs: Fix page_mkwrite off-by-one errors

----- Ursprüngliche Mail -----
> Von: "Andreas Gruenbacher" <agruenba@...hat.com>
> An: "Christoph Hellwig" <hch@...radead.org>, "Darrick" <darrick.wong@...cle.com>
> CC: "Andreas Gruenbacher" <agruenba@...hat.com>, "torvalds" <torvalds@...ux-foundation.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>, "Al Viro" <viro@...iv.linux.org.uk>, "Jeff Layton" <jlayton@...nel.org>, "Sage Weil"
> <sage@...hat.com>, "Ilya Dryomov" <idryomov@...il.com>, "tytso" <tytso@....edu>, "Andreas Dilger"
> <adilger.kernel@...ger.ca>, "Jaegeuk Kim" <jaegeuk@...nel.org>, "Chao Yu" <chao@...nel.org>, linux-xfs@...r.kernel.org,
> "linux-fsdevel" <linux-fsdevel@...r.kernel.org>, "richard" <richard@....at>, "Artem Bityutskiy" <dedekind1@...il.com>,
> "Adrian Hunter" <adrian.hunter@...el.com>, ceph-devel@...r.kernel.org, linux-ext4@...r.kernel.org,
> linux-f2fs-devel@...ts.sourceforge.net, "linux-mtd" <linux-mtd@...ts.infradead.org>, "Chris Mason" <clm@...com>, "Josef
> Bacik" <josef@...icpanda.com>, "David Sterba" <dsterba@...e.com>, "linux-btrfs" <linux-btrfs@...r.kernel.org>
> Gesendet: Freitag, 29. November 2019 15:20:45
> Betreff: [PATCH v2] fs: Fix page_mkwrite off-by-one errors

> The check in block_page_mkwrite meant to determine whether an offset is
> within the inode size is off by one.  This bug has spread to
> iomap_page_mkwrite and to several filesystems (ubifs, ext4, f2fs, ceph).
> To fix that, introduce a new page_mkwrite_check_truncate helper that
> checks for truncate and computes the bytes in the page up to EOF, and
> use that helper in the above mentioned filesystems and in btrfs.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>

Thank you for fixing UBIFS!

Acked-by: Richard Weinberger <richard@....at>

Thanks,
//richard