lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200116184733.GD24522@iweiny-DESK2.sc.intel.com> Date: Thu, 16 Jan 2020 10:47:34 -0800 From: Ira Weiny <ira.weiny@...el.com> To: Jan Kara <jack@...e.cz> Cc: linux-kernel@...r.kernel.org, Alexander Viro <viro@...iv.linux.org.uk>, "Darrick J. Wong" <darrick.wong@...cle.com>, Dan Williams <dan.j.williams@...el.com>, Dave Chinner <david@...morbit.com>, Christoph Hellwig <hch@....de>, "Theodore Y. Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: Re: [RFC PATCH V2 05/12] fs: remove unneeded IS_DAX() check On Thu, Jan 16, 2020 at 10:38:07AM +0100, Jan Kara wrote: > On Fri 10-01-20 11:29:35, ira.weiny@...el.com wrote: > > From: Ira Weiny <ira.weiny@...el.com> > > > > The IS_DAX() check in io_is_direct() causes a race between changing the > > DAX mode and creating the iocb flags. > > > > Remove the check because DAX now emulates the page cache API and > > therefore it does not matter if the file mode is DAX or not when the > > iocb flags are created. > > > > Signed-off-by: Ira Weiny <ira.weiny@...el.com> > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@...e.cz> Thanks, Ira > > Honza > > > --- > > include/linux/fs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index d7584bcef5d3..e11989502eac 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -3365,7 +3365,7 @@ extern int file_update_time(struct file *file); > > > > static inline bool io_is_direct(struct file *filp) > > { > > - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); > > + return (filp->f_flags & O_DIRECT); > > } > > > > static inline bool vma_is_dax(struct vm_area_struct *vma) > > -- > > 2.21.0 > > > -- > Jan Kara <jack@...e.com> > SUSE Labs, CR
Powered by blists - more mailing lists