linux-ext4 - Re: [PATCH v2] jbd2: remove pointless assertion in __journal_remove_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200125072612.GG1108497@mit.edu>
Date:   Sat, 25 Jan 2020 02:26:12 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Shijie Luo <luoshijie1@...wei.com>
Cc:     linux-ext4@...r.kernel.org, jack@...e.cz
Subject: Re: [PATCH v2] jbd2: remove pointless assertion in
 __journal_remove_journal_head

On Thu, Jan 23, 2020 at 02:00:54AM -0500, Shijie Luo wrote:
> Only when jh->b_jcount = 0 in jbd2_journal_put_journal_head, we are allowed
> to call __journal_remove_journal_head. This assertion is meaningless,
> just remove it.
> 
> Signed-off-by: Shijie Luo <luoshijie1@...wei.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted