lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Jan 2020 02:31:09 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: Vasily Averin <vvs@...tuozzo.com>, linux-ext4@...r.kernel.org, Jan Kara <jack@...e.com> Subject: Re: [PATCH 1/1] jbd2_seq_info_next should increase position index On Thu, Jan 23, 2020 at 03:02:43PM +0100, Jan Kara wrote: > On Thu 23-01-20 14:30:14, Vasily Averin wrote: > > > > > > On 1/23/20 2:15 PM, Jan Kara wrote: > > > On Thu 23-01-20 12:05:10, Vasily Averin wrote: > > >> if seq_file .next fuction does not change position index, > > >> read after some lseek can generate unexpected output. > > >> > > >> Script below generates endless output > > >> $ q=;while read -r r;do echo "$((++q)) $r";done </proc/fs/jbd2/DEV/info > > > > > > I've just tried and this works for me just fine with openSUSE 15.1 > > > (4.12.14-based) kernel. Is it some recent regression? > > > > I think it depends on > > commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") > > In OpenVz7 we got complain after backport of this patch. > > I see. OK. So please add tag: > > Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") > > likely also: > > CC: stable@...r.kernel.org > > and you can also add: > > Reviewed-by: Jan Kara <jack@...e.cz> Thanks, applied with the suggested tags. - Ted
Powered by blists - more mailing lists