lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Jan 2020 02:59:40 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: "zhangyi (F)" <yi.zhang@...wei.com>, linux-ext4@...r.kernel.org, jack@...e.com, adilger.kernel@...ger.ca, liangyun2@...wei.com, luoshijie1@...wei.com Subject: Re: [PATCH v3 2/4] ext4, jbd2: ensure panic when aborting with zero errno On Wed, Dec 04, 2019 at 01:52:13PM +0100, Jan Kara wrote: > On Wed 04-12-19 20:46:12, zhangyi (F) wrote: > > JBD2_REC_ERR flag used to indicate the errno has been updated when jbd2 > > aborted, and then __ext4_abort() and ext4_handle_error() can invoke > > panic if ERRORS_PANIC is specified. But if the journal has been aborted > > with zero errno, jbd2_journal_abort() didn't set this flag so we can > > no longer panic. Fix this by always record the proper errno in the > > journal superblock. > > > > Fixes: 4327ba52afd03 ("ext4, jbd2: ensure entering into panic after recording an error in superblock") > > Signed-off-by: zhangyi (F) <yi.zhang@...wei.com> > > Looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@...e.cz> Applied, thanks. - Ted
Powered by blists - more mailing lists